Skip to content

Exit full-screen mode when a full-screen card is removed #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 15, 2024
Merged

Exit full-screen mode when a full-screen card is removed #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4b483b8
fix(card): Exit full-screen mode when a full-screen card is removed
gadenbuie Mar 12, 2024
727ab49
chore: yarn build
gadenbuie Mar 12, 2024
565ce17
refactor(card): Just observe `document.body` for removals
gadenbuie Mar 12, 2024
ff36189
fix: find nested matching elements
gadenbuie Mar 12, 2024
04f3ccf
chore: yarn build
gadenbuie Mar 12, 2024
ed12ff1
Resave distributed files (GitHub Action)
gadenbuie Mar 12, 2024
4b1ad1d
Merge "origin/main" into branch card/fix-fullscreen-exit-by-removal
gadenbuie Mar 12, 2024
ef140d8
Resave distributed files (GitHub Action)
gadenbuie Mar 12, 2024
75100e7
Resave data (GitHub Action)
gadenbuie Mar 12, 2024
97b64e4
refactor: Use a Set instead of an array for `found` removed items
gadenbuie Mar 14, 2024
e54ad13
chore: yarn build
gadenbuie Mar 14, 2024
492799e
chore: try/catch `ShinyRemovedObserver` callback
gadenbuie Mar 14, 2024
4df8849
Merge 'origin/main' into branch 'card/fix-fullscreen-exit-by-removal'
gadenbuie Mar 14, 2024
3955947
`yarn build` (GitHub Actions)
gadenbuie Mar 14, 2024
e2bb643
docs(news): Add news item
gadenbuie Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@

* `page_navbar()` and `navset_bar()` now validate and transform `padding` and `gap` arguments into appropriate CSS values. (#991)

* Fixed an issue that could happen with a `card()` or `value_box()` that is rendered entirely via `renderUI()` when it is replaced by an updated card but the user had expanded the original card into full screen mode. Now the full screen state is reset for the new card or value box. If you want to update a card without potentially exiting the full-screen mode, update specific parts of the card using `uiOutput()` or `textOutput()`. (#1005)

# bslib 0.6.1

## Bug fixes
Expand Down
130 changes: 130 additions & 0 deletions inst/components/dist/components.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions inst/components/dist/components.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading