Drop outdated documentation #2342
Conversation
|
|
||
| ### Install the bundle | ||
|
|
||
| $ bundle install |
There was a problem hiding this comment.
install is not enough as it doesn't add to Gemfile.lock.
There was a problem hiding this comment.
Can you clarify? I thought bundle was short for bundle install and should be sufficient for a new app...
There was a problem hiding this comment.
Install the gems specified in your Gemfile(5). If this is the first time you run bundle install (and a Gemfile.lock does not exist), Bundler will fetch all remote sources, resolve dependencies and install all needed gems.
You're right. I had an impression that bundle install is not supposed to create/update Gemfile.lock. It seems that it's only the case for bundle install --frozen.
Will revert this.
|
|
||
| ### Run RSpec | ||
|
|
||
| $ rake spec |
There was a problem hiding this comment.
Never using this, not sure if it can/should be rails spec now or rake is preferrable just like with running other common tasks.
There was a problem hiding this comment.
| 4.2 | >= 3.1 | ||
| 5.0 | >= 3.5 | ||
| 5.1 | >= 3.6 | ||
| 5.2 | >= 3.8 |
There was a problem hiding this comment.
It might be that Rails 5.2 was supported in 3.6/3.7, but in 3.8 there were some fixes to improve Rails 5.2 support.
| @@ -1,5 +1,3 @@ | |||
| - upgrade: | |||
| - from_1x_to_2x.md (From rspec-rails-1.x to rspec-rails-2) | |||
| 4.2 | >= 3.1 | ||
| 5.0 | >= 3.5 | ||
| 5.1 | >= 3.6 | ||
| 5.2 | >= 3.8 |
|
|
||
| ### Run RSpec | ||
|
|
||
| $ rake spec |
features/upgrade/README.md
Outdated
| RSpec Rails 4 requires Ruby 2.2. | ||
|
|
||
| There are several changes specific to `rspec-rails` to be aware of: | ||
| Please also keep in mind that even though RSpec Rails 4 has soft support for Rails 4.2, it's recommended to use Rails 5+. | ||
|
|
||
| - [Default helper files created in RSpec 3.x have changed](#default-helper-files) | ||
| Other than that, there is nothing that needs to be done to upgrade from RSpec Rails 3 to version 4.0. |
There was a problem hiding this comment.
I would rephrase this, I feel its important to emphasise the last part, and less so the first part.
| RSpec Rails 4 requires Ruby 2.2. | |
| There are several changes specific to `rspec-rails` to be aware of: | |
| Please also keep in mind that even though RSpec Rails 4 has soft support for Rails 4.2, it's recommended to use Rails 5+. | |
| - [Default helper files created in RSpec 3.x have changed](#default-helper-files) | |
| Other than that, there is nothing that needs to be done to upgrade from RSpec Rails 3 to version 4.0. | |
| RSpec Rails 4 is a major version under semantic versioning, it allowed us to change the supported Rails versions to 5 and 6 only. There are no changes required to upgrade to RSpec Rails 4 if you are using Rails 5 or 6. | |
| If you are using Rails 4.2 you can use RSpec Rails 4, but note that support for it is not maintained, we consider this a breaking change hence the version change, and you must be on Ruby 2.2 as a minimum. |
Mostly related to either RSpec Rails 3 or even earlier.
3 participants
Mostly related to either RSpec Rails 3 or even earlier.