This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Add SnippetExtractor spec examples for end-less methods support #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujinakayama
force-pushed
the
support-end-less-methods-in-snippet-extractor
branch
2 times, most recently
from
fc7b79f to
3faa7fc
Compare
yujinakayama
force-pushed
the
support-end-less-methods-in-snippet-extractor
branch
from
3faa7fc to
6c013bd
Compare
yujinakayama
force-pushed
the
support-end-less-methods-in-snippet-extractor
branch
2 times, most recently
from
7eed81d to
529a0bb
Compare
JonRowe
reviewed
Oct 26, 2021
| @@ -1,7 +1,11 @@ | |||
| require 'rspec/core/formatters/snippet_extractor' | |||
| require 'support/helper_methods' | |||
| require 'tempfile' | |||
Member
There was a problem hiding this comment.
This should be done in a sub process to prevent false positives in rspec-core cause by our requiring it.
Member
There was a problem hiding this comment.
Apologies, I meant the require, its important the require is done in a sub process.
yujinakayama
force-pushed
the
support-end-less-methods-in-snippet-extractor
branch
from
529a0bb to
6ed9d68
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds spec examples for #2892.
Actual fix is done in rspec/rspec-support#505.