This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Expose a better inspect value for Example::Procsy #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you paste before/after examples for what the inspect output was like? |
Member
Author
|
Before: After: |
Member
|
I like the "After" version. 👍 |
Member
|
LGTM |
[skip ci]
JonRowe
added a commit
that referenced
this pull request
Jun 28, 2014
Expose a better inspect value for Example::Procsy
Member
Author
|
So I umed and ahed and decided I deem this an enhancement and therefore haven't back ported it to 3-0-maintenance, willing to do so if others think it's worthwhile. |
Member
|
Sounds like an ER to me. |
Member
Author
|
ER? |
Member
|
Enhancement Request |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Expose a better inspect value for Example::Procsy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1619 it occurs to me that we shouldn't tell people that the procsy object is a proc (currently inspect exposes the proc's inspect string), so I propose we either use just the example string or as I've done a modified example string to make it clear it's a proxy object to the example.