This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Document tag name:value pair limitation. #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
features/command_line/tag.feature
Outdated
Member
There was a problem hiding this comment.
Saying they are merged suggests that this is an active, intentional thing we've written code to do. It's not...it's just that filters are represented internally as a hash and hashes don't allow multiple entries for the same key. I think I'd write this as:
Filters are represented internally as a hash, which means that you can't
specify multiple filters for the same key. If you try to exclude `:name => 'foo'`
and `:name => 'bar'`, you will only end up excluding `:name => 'bar'`.
Member
There was a problem hiding this comment.
Or without mentioning the implementation details:
Filters that use the same `name` in a `name:value` pair will be overwritten,
so if you try to exclude `:name => 'foo'` and `:name => 'bar'`, you will only
end up excluding `:name => 'bar'`.
Member
There was a problem hiding this comment.
I think it's good for people to have the mental model of metadata (and by extension tags) as being represented by a hash...
Member
|
Also, can you squash this into one commit? |
Contributor
Author
|
Updated w/ @myronmarston's proposed wording and squashed. |
JonRowe
added a commit
that referenced
this pull request
Jun 27, 2014
Document tag name:value pair limitation.
Member
|
Thank @maxlinc |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Document tag name:value pair limitation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the limitation described in #1614. Please leave that issue open as a feature request.