Skip to content

Conversation

plantarum
Copy link

This addresses #12 , along with a few other related minor issues.

I tried to make the changes very granular, one/few change per commit, in the hopes that you will be able to accept or reject each one as you like.

Let me know if this is useful, or if you'd like me to change anything at my end.

  • Tyler

smithty added 8 commits July 27, 2023 18:06
Removed '*' wildcard reference, switched references to `dismo::gbif`
function to `geodata::sp_occurrence`. A few typos corrected.
The original version of the map excluded Pakistan, which was discussed in
the subsequent text.
The original transposed the polygons and vectors in the function call. Also
corrected reference to wrld_simpl in the following text to wrld.
Maybe not necessary, but this ensures the extend function *always* extends
the grid. No difference in this example, but in some cases it could result
in the grid remaining the same size in one or more dimensions, if a point
falls exactly on the edge of the grid. That's suprising and easy to miss,
so I prefer to do this explicitly.
gbif -> sp_occurrence, wrld_simpl -> world
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant