Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 19, 2021

NOTE: Depends on #179

  • gradle 7.2
  • remove playground and publish check
  • minor update of versions
  • enable version catalogs, typesafe project accessors
  • create and use convention plugins:
    • rsocket-build - basic configuration of any module
    • rsocket-build-js - configuration of JS target
    • rsocket-build-jvm - configuration of JVM target
    • rsocket-build-native - configuration of native targets
    • rsocket-build-multiplatform - configuration of all targets
    • rsocket-build-publish - configuration of maven-central/artifactory publication and singing
    • rsocket-build-library - base configuration for library module (publishing + explicitApi mode)
  • improve RSocketTestServer configuration

@@ -0,0 +1,61 @@
import org.gradle.api.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this in buildSrc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this task should be configured in 2 places:

  1. in rsocket-test-server to provide executable
  2. in modules, which need to run this task - for now it's only used in rsocket-transport-ktor for JS. But also will be useful if/when we will implement plain ios(darwin) transport iOS websocket transport example #111

now adding dependencies on this TestServer is simple as adding call in a module. Before we need to be sure that we call evaluationDependsOn in depending module and adding new module name in rsocket-test-server

@ghost ghost marked this pull request as ready for review August 19, 2021 12:38
olme04 added 7 commits August 19, 2021 17:38
test JS WS Client transport
update pipelines to run ktor JS tests
minor update of versions
create convention plugins in buildSrc:
* rsocket-build - basic configuration of any module
* rsocket-build-js - configuration of JS target
* rsocket-build-jvm - configuration of JVM target
* rsocket-build-native - configuration of native targets
* rsocket-build-multiplatform - configuration of all targets
* rsocket-build-publish - configuration of maven-central/artifactory publication and singing
* rsocket-build-library - base configuration for library module (publishing + explicitApi mode)
@ghost
Copy link
Author

ghost commented Dec 18, 2021

Suppressed by #190 #197 #198 #199

@ghost ghost closed this Dec 18, 2021
@ghost ghost deleted the build-update branch December 20, 2021 14:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant