Use static errors in RSocket default method implementations #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
spencergibb
approved these changes
Sep 22, 2020
robotmrv
reviewed
Sep 23, 2020
Closes rsocketgh-887 Signed-off-by: Rossen Stoyanchev <[email protected]>
Closes rsocketgh-865 Signed-off-by: Rossen Stoyanchev <[email protected]>
Signed-off-by: Rossen Stoyanchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes for #865.
I think limiting the rate of any individual request type is up to RSocket responder implementations. By default we can at least ensure minimal processing overhead.