ReactiveSocket interface #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robertroeser
commented
Mar 27, 2016
robertroeser
commented
- updated to agrona 0.4.13
- pinned to the correct rxjava 2 snapshot so unit tests pass
- refactored the ReactiveSocket class into an interface and implementation class
…version of rxjava2 to get the tests to work, updated Agrona to 0.4.13
…version of rxjava2 to get the tests to work, updated Agrona to 0.4.13
| /** | ||
| * An implementation of {@link ReactiveSocket} | ||
| */ | ||
| public class ReactiveSocketImpl implements ReactiveSocket { |
There was a problem hiding this comment.
I like Netty's convention of naming default implementation as Default*, in that case, DefaultReactiveSocket.
|
Other that the naming that I would like to improve, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.