Skip to content

Thin style service name syntax for 23c support #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Thin style service name syntax for 23c support #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb6ab1
Fix ORA-12505 When Connecting Using Jdbc
silkPK Sep 28, 2023
3fb328b
changed version
silkPK Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion History.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
== 0.8.1 2023-09-28
* Improvements
* Support Oracle Database 23c [#229]

== 0.8.0 2021-08-10
* Improvements and fixes
* Support Rails 6.1 [#193]
Expand All @@ -24,7 +28,7 @@

== 0.7.1 2018-09-03
* Fix
* Address incorrect versions in Gemfile
* Address incorrect versions in Gemfile

== 0.7.0 2018-09-03
* Improvements and fixes
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.8.0
0.8.1
4 changes: 2 additions & 2 deletions lib/plsql/jdbc_connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ def self.create_raw(params)
url = if ENV["TNS_ADMIN"] && database && !params[:host] && !params[:url]
"jdbc:oracle:thin:@#{database}"
else
database = ":#{database}" unless database.match(/^(\:|\/)/)
params[:url] || "jdbc:oracle:thin:@#{params[:host] || 'localhost'}:#{params[:port] || 1521}#{database}"
database = "/#{database}" unless database.match(/^(\:|\/)/)
params[:url] || "jdbc:oracle:thin:@//#{params[:host] || 'localhost'}:#{params[:port] || 1521}#{database}"
end
new(java.sql.DriverManager.getConnection(url, params[:username], params[:password]))
end
Expand Down
4 changes: 2 additions & 2 deletions ruby-plsql.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
# Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
# -*- encoding: utf-8 -*-

# stub: ruby-plsql 0.8.0 ruby lib
# stub: ruby-plsql 0.8.1 ruby lib

Gem::Specification.new do |s|
s.name = "ruby-plsql".freeze
s.version = "0.8.0"
s.version = "0.8.1"

s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
s.require_paths = ["lib".freeze]
Expand Down