Skip to content

Conversation

@olegafx
Copy link
Contributor

@olegafx olegafx commented Jun 24, 2016

SVG icons uses fill property to set colors

@rsanchez
Copy link
Owner

Thanks. Can you add a test to test/test.js?

    it('should extract fill.', function (done) {
        test(
            'svg { fill: red; } p { display: block; }',
            ['red'],
            {},
            done
        );
    });

@olegafx
Copy link
Contributor Author

olegafx commented Jun 24, 2016

Done. But now build check failed. Is it ok?…

test/test.js Outdated
done
);
});

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olegafx This is the line causing the CI to fail.

test/test.js
  240:1  error  Trailing spaces not allowed  no-trailing-spaces

Making this line a blank line instead of 4 spaces should fix it. Do that and I'll merge. :D

@rsanchez rsanchez merged commit 8b05700 into rsanchez:master Jun 24, 2016
@rsanchez
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants