Skip to content

bugfix: Sort attributes to make rr_* attributes handled last #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2022
Merged

bugfix: Sort attributes to make rr_* attributes handled last #970

merged 4 commits into from
Sep 26, 2022

Conversation

@Juice10
Copy link
Member

@Juice10 Juice10 commented Aug 22, 2022

rr_dataURL overwrites src attribute, because of this we need to evaluate rr_dataURL last so src doesn't accidentally get overwritten again.

@Juice10
Sort attributes to make rr_* attributes handled last
ad24bfd 
`rr_dataURL` overwrites `src` attribute, because of this we need to evaluate `rr_dataURL` last so it doesn't accidentally get overwritten again.
@Juice10 Juice10 changed the title Sort attributes to make rr_* attributes handled last bugfix: Sort attributes to make rr_* attributes handled last Aug 22, 2022
Juice10
Juice10 commented Aug 24, 2022
View reviewed changes
Yuyz0112
Yuyz0112 reviewed Sep 1, 2022
View reviewed changes
@Juice10
Copy link
Member Author

Juice10 commented Sep 16, 2022

Had a chat with @eoghanmurray and @Mark-Fenng, I'm going to do a refactor which eliminates the loop overhead.

eoghanmurray
eoghanmurray requested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@eoghanmurray eoghanmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got the alternative version without the specialAttributes array, but with the boolean flag?

@Juice10
Copy link
Member Author

Juice10 commented Sep 21, 2022

I think you've got the alternative version without the specialAttributes array, but with the boolean flag?

@eoghanmurray I did some performance tests and this one was faster so I ended up going with this

@eoghanmurray
Copy link
Contributor

eoghanmurray commented Sep 21, 2022

Cool, happy to approve!
This way is also elegant now that I see it.
I thought the specialAttributes was from before Friday when we had a chat about it.

@Juice10
Copy link
Member Author

Juice10 commented Sep 21, 2022

@eoghanmurray thanks Eoghan! Yes it was from our chat initially. But it got deleted and then came back again

YunFeng0817
YunFeng0817 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A clean and performant version.

@Yuyz0112 Yuyz0112 merged commit 23e3a73 into master Sep 26, 2022
@YunFeng0817 YunFeng0817 deleted the attribute-order branch September 27, 2022 05:38
@Juice10 Juice10 added the 2.0 label Dec 1, 2022
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eoghanmurray eoghanmurray eoghanmurray requested changes

@Yuyz0112 Yuyz0112 Yuyz0112 approved these changes

@YunFeng0817 YunFeng0817 YunFeng0817 approved these changes

Assignees

No one assigned

Labels

2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Juice10 @eoghanmurray @Yuyz0112 @YunFeng0817