feat: add a destroy function to destroy the whole player #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juice10
approved these changes
Aug 11, 2022
Co-authored-by: Justin Halsall <[email protected]>
Yuyz0112
approved these changes
Aug 11, 2022
Member
Yuyz0112
left a comment
Yuyz0112
left a comment
There was a problem hiding this comment.
LGTM
Maybe we can improve this implementation by rejecting further function calls after being destroyed. But at this moment, I think the current implementation is good enough.
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a destroy function to remove the player from dom. Also, try to fix #883.
Changes in the PR: