fix: canvas data in iframe wasn't applied in the fast-forward mode #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juice10
requested changes
Jul 25, 2022
Member
Juice10
left a comment
Juice10
left a comment
There was a problem hiding this comment.
Good catch! Found one little tweak to make the code slightly more robust
Co-authored-by: Justin Halsall <[email protected]>
…web-io/rrweb into virtual-dom-iframe-canvas-fix
Yuyz0112
approved these changes
Jul 31, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #853, I implemented the virtual dom for the fast-forward mode. But there is a corner case I didn't deal with.
If a canvas element is created with image data (serialized to
rr_dataURL) in an iframe, it will be rebuilt as an empty canvas without the initial image data, in the fast-forward mode (using Virtual Dom optimization).A simple test case is also added in this PR to reproduce this corner case.