rrweb: add selection observer #936
Conversation
|
@0jinxing Thanks! This looks interesting, could you provide more information about the use case of this feature, and a short video demo for the replay effect? BTW, e2e test cases are required. |
|
@0jinxing Thanks for your excellent feature contribution. record.mp4replay.mp4I am looking forward to seeing the complementation and merge of this PR! |
0jinxing
force-pushed
the
master
branch
2 times, most recently
from
dc5d8d6 to
c3295f0
Compare
Co-authored-by: Yun Feng <[email protected]>
Co-authored-by: Yun Feng <[email protected]>
Co-authored-by: Yun Feng <[email protected]>
Co-authored-by: Yun Feng <[email protected]>
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
@0jinxing Thanks for your quick modification and reply! Hope to see it merged soon.
|
Thanks, let's merge it! |
|
|
||
| updateSelection(); | ||
|
|
||
| return on('selectionchange', updateSelection); |
There was a problem hiding this comment.
The on function here expects a third 'target' argument; I presume it should be doc?
There was a problem hiding this comment.
@0jinxing can you confirm that it should be doc passed as the third argument?
Otherwise it's trying to addEventListener on undefined
There was a problem hiding this comment.
@YunFeng0817 I'm not sure how this has escaped everyone's notice if it's been merged!
5 participants
support selection change record and replay