refactor: eliminate eslint errors #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
nice |
YunFeng0817
force-pushed
the
eslint-error-hunter
branch
from
03bbcf7 to
433b6ca
Compare
Member
|
You are an absolute hero @Mark-Fenng! Thank you for this! |
Juice10
reviewed
Jul 4, 2022
Yuyz0112
approved these changes
Jul 10, 2022
Member
Yuyz0112
left a comment
Yuyz0112
left a comment
There was a problem hiding this comment.
I think we can remove tslint in a following PR
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #900, we replaceed tslint with eslint with stricter lint rues, which is an excellent start to improving code quality. But unfixed lint errors keep slowing down our development speed. I create this PR to make it a base for more fixing code. This can also help avoid conflicts over the changes we all made. Welcome to fix more eslint errors based on this PR.