Monkeypatch each iframe #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w versions of them were for the following reason: https://stackoverflow.com/questions/60245787/
…expected and which are to be ignored
…ames - particularly important for those which rely on prototype monkeypatching
Member
|
Also found these bugs, good job 👍 . Going to review in the coming holiday. |
Juice10
requested changes
Sep 29, 2021
…ing applies to all windows
Contributor
Author
|
Working on the typings suggestions from Justin, thanks @Juice10! |
eoghanmurray
force-pushed
the
monkeypatch-each-iframe
branch
from
18628d2 to
cbf4320
Compare
Contributor
Author
|
Thanks @Juice10 I think all the review suggestions have been incorporated with the last force-push |
Member
|
LGTM, and I will send a PR try to reduce the usage of |
Yuyz0112
added a commit
that referenced
this pull request
Oct 1, 2021
eoghanmurray
referenced
this pull request
in fouad1998/rrweb
Oct 1, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observers which worked by monkeypatching built in objects were not working within iFrames as these have their own clean window object which doesn't include the iframe