fix for 'suspendMutationsDuringSnapshot' #385 #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing during `takeFullSnapshot` was causing mutations to be immediately emitted, contrary to the goal of rrweb-io#385
Member
|
Thanks |
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Feb 3, 2021
…ing during `takeFullSnapshot` was causing mutations to be immediately emitted, contrary to the goal of rrweb-io#385 (rrweb-io#470)
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Feb 22, 2021
…ing during `takeFullSnapshot` was causing mutations to be immediately emitted, contrary to the goal of rrweb-io#385 (rrweb-io#470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that the common case of mouse movement or scrolling happening during
takeFullSnapshotwas causing mutations to be immediately emitted, contrary to the goal of #385Instead create two different types of 'lock' for mutations, one to do with freezes initiated by inactivity (which can be unlocked by any new non-mutation activity) and another lock during fullSnapshot, which can't be unlocked until the fullSnapshot is finished.