Skip to content

Verifying the type of node during mutation of attributes #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Verifying the type of node during mutation of attributes #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/replay/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,9 @@ export class Replayer {
if (!target) {
return this.warnNodeNotFound(d, mutation.id);
}
if(target.nodeType !== 1) {
return this.warnNodeIsNotAnElement(d, mutation.id);
}
for (const attributeName in mutation.attributes) {
if (typeof attributeName === 'string') {
const value = mutation.attributes[attributeName];
Expand Down Expand Up @@ -793,4 +796,14 @@ export class Replayer {
// tslint:disable-next-line: no-console
console.log(REPLAY_CONSOLE_PREFIX, `Node with id '${id}' not found in`, d);
}

private warnNodeIsNotAnElement(d: incrementalData, id: number) {
/**
* In some cases, the node must be of type Element
*/
if (!this.config.showWarning) {
return;
}
console.warn(REPLAY_CONSOLE_PREFIX, `Node with id '${id}' is not an 'Element' type in`, d);
}
}