Skip to content

Conversation

@billyvg
Copy link
Contributor

@billyvg billyvg commented Jul 17, 2023

Allows maskTextFn to access to parent element or node so that it can make masking decisions based on the element. This brings the interface to be similar to maskInputFn.

Allows `maskTextFn` to access to parent element or node so that it can make masking decisions based on the element.
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

🦋 Changeset detected

Latest commit: 07c18b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
rrweb-snapshot Patch
rrweb Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch
rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@billyvg billyvg marked this pull request as ready for review July 25, 2023 13:21
@eoghanmurray
Copy link
Contributor

Looks good
(I presume you've checked passing in a function which doesn't deal with the second parameter? - that would be fine, right?)

@benjackwhite
Copy link
Contributor

Only just noticed this PR exists! I just did the same thing but with some slightly stricter typing and tests.

#1310

@billyvg
Copy link
Contributor Author

billyvg commented Sep 29, 2023

Closing in favor of #1310

@billyvg billyvg closed this Sep 29, 2023
@billyvg billyvg deleted the feat-pass-element-to-maskTextFn branch September 29, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants