rrvideo: improve the video quality and add a progress bar for the CLI tool #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 553719e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
approved these changes
May 1, 2023
This was referenced May 1, 2023
This was referenced Jul 6, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
… tool (rrweb-io#1197) * refactor rrvideo: use playwright rather than puppeteer * add a progress bar for the tool * add tests for cli.ts * fix build error * add change log * update readme file * Apply a scaling method to improve the resolution of the output video
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
… tool (rrweb-io#1197) * refactor rrvideo: use playwright rather than puppeteer * add a progress bar for the tool * add tests for cli.ts * fix build error * add change log * update readme file * Apply a scaling method to improve the resolution of the output video
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
… tool (rrweb-io#1197) * refactor rrvideo: use playwright rather than puppeteer * add a progress bar for the tool * add tests for cli.ts * fix build error * add change log * update readme file * Apply a scaling method to improve the resolution of the output video
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 3, 2023
… tool (rrweb-io#1197) * refactor rrvideo: use playwright rather than puppeteer * add a progress bar for the tool * add tests for cli.ts * fix build error * add change log * update readme file * Apply a scaling method to improve the resolution of the output video
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
… tool (rrweb-io#1197) * refactor rrvideo: use playwright rather than puppeteer * add a progress bar for the tool * add tests for cli.ts * fix build error * add change log * update readme file * Apply a scaling method to improve the resolution of the output video
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
… tool (rrweb-io#1197) * refactor rrvideo: use playwright rather than puppeteer * add a progress bar for the tool * add tests for cli.ts * fix build error * add change log * update readme file * Apply a scaling method to improve the resolution of the output video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1182 and resolves rrweb-io/rrvideo#23.
Changes:
Demo:
progress bar:
demo.mp4
generated video:
demo.webm