-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix the statement which is getting changed by Microbundle #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: eefc0f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Good catch @Code-Crash! |
|
Sure, thanks. |
Juice10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Code-Crash
|
FYI: @Juice10 In Microbundle, it's expected behavior, please see the thread : developit/microbundle#1029 |
|
Thanks for sharing @Code-Crash |
While testing the cross-origin iframe feature, I realized that with the compressed version, it's not working and without compression, it's working, after digging into it, I found that, the microbundle is not converting a single line statement properly, please see the attached screenshot.
I will also add this issue to the microbundle issue list as well, however, I think it should be good if we could change the statement properly, or else anyway it will crash, and catch will handle it for cross-origin iframes.
We can see in the below image,
window.parent.documentis there as a normal statement, which gets trimmed somehow aswindowin the next compressed version of the image.We can see here, it's getting replaced as
windowonly, which is causing cross-origin iframe not able to work as expected.So, if we use this as a proper statement as per this pull request, it's working fine, please see if we can merge it @Juice10