Skip to content

Fix relative path detection in stylesheet URLs #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Fix relative path detection in stylesheet URLs #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84368dc
Fix relative path detection in stylesheet URLs
Equlnox Feb 14, 2023
41ad59f
Add a check for www.
Equlnox Feb 14, 2023
941385a
Update packages/rrweb-snapshot/src/snapshot.ts
Juice10 Feb 14, 2023
d9ae269
Update packages/rrweb-snapshot/src/snapshot.ts
YunFeng0817 Feb 14, 2023
09f1e27
Create large-ants-prove.md
YunFeng0817 Feb 14, 2023
210a02e
Update large-ants-prove.md
YunFeng0817 Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/large-ants-prove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'rrweb-snapshot': patch
'rrweb': patch
---

Fix: Make relative path detection in stylesheet URLs to detect more types of URL protocols when inlining stylesheets.
5 changes: 3 additions & 2 deletions packages/rrweb-snapshot/src/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ let canvasService: HTMLCanvasElement | null;
let canvasCtx: CanvasRenderingContext2D | null;

const URL_IN_CSS_REF = /url\((?:(')([^']*)'|(")(.*?)"|([^)]*))\)/gm;
const RELATIVE_PATH = /^(?!www\.|(?:http|ftp)s?:\/\/|[A-Za-z]:\\|\/\/|#).*/;
const URL_PROTOCOL_MATCH = /^(?:[a-z+]+:)?\/\//i;
const URL_WWW_MATCH = /^www\..*/i;
const DATA_URI = /^(data:)([^,]*),(.*)/i;
export function absoluteToStylesheet(
cssText: string | null,
Expand All @@ -92,7 +93,7 @@ export function absoluteToStylesheet(
if (!filePath) {
return origin;
}
if (!RELATIVE_PATH.test(filePath)) {
if (URL_PROTOCOL_MATCH.test(filePath) || URL_WWW_MATCH.test(filePath)) {
return `url(${maybeQuote}${filePath}${maybeQuote})`;
}
if (DATA_URI.test(filePath)) {
Expand Down