Skip to content

fix: Exclude scripts loaded with rel=modulepreload from snapshots #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: Exclude scripts loaded with rel=modulepreload from snapshots #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
564905d
fix: Exclude `modulepreload` as well
billyvg Feb 13, 2023
84605b5
Apply formatting changes
billyvg Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/rrweb-snapshot/src/rebuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ function buildNode(
continue;
} else if (
tagName === 'link' &&
n.attributes.rel === 'preload' &&
(n.attributes.rel === 'preload' ||
n.attributes.rel === 'modulepreload') &&
n.attributes.as === 'script'
) {
// ignore
Expand Down
5 changes: 3 additions & 2 deletions packages/rrweb-snapshot/src/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,9 +813,10 @@ function slimDOMExcluded(
slimDOMOptions.script &&
// script tag
(sn.tagName === 'script' ||
// preload link
// (module)preload link
(sn.tagName === 'link' &&
sn.attributes.rel === 'preload' &&
(sn.attributes.rel === 'preload' ||
sn.attributes.rel === 'modulepreload') &&
sn.attributes.as === 'script') ||
// prefetch link
(sn.tagName === 'link' &&
Expand Down
1 change: 1 addition & 0 deletions packages/rrweb-snapshot/test/__snapshots__/integration.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ exports[`integration tests [html file]: preload.html 1`] = `
<title>Document</title>
<link />
<link />
<link />
</head>
<body></body></html>"
`;
Expand Down
1 change: 1 addition & 0 deletions packages/rrweb-snapshot/test/html/preload.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
<link rel="modulepreload" href="https://example/path/to/preload.js" as="script" />
<link rel="preload" href="https://example/path/to/preload.js" as="script" />
<link rel="prefetch" href="https://example/path/to/prefetch.js" />
</head>
Expand Down