Don't have requestAnimationFrame looping in background for Live Mode #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- instead restart the loop when a new action is added
YunFeng0817
reviewed
Feb 9, 2023
Member
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
Most of code looks good to me.
| // extend finish event if the last event is a mouse move so that the timer isn't stopped by the service before checking the last event | ||
| finish_buffer += Math.max(0, -event.data.positions[0].timeOffset); | ||
| } | ||
| setTimeout(finish, finish_buffer); |
Juice10
reviewed
Feb 9, 2023
Co-authored-by: Yun Feng <[email protected]>
Juice10
approved these changes
Feb 9, 2023
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't have requestAnimationFrame looping in background for Live Mode - instead restart the loop when a new action is added