-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
improve rrdom robustness #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
improve rrdom robustness #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add try catch to some fragile points
c278bb1 to
011abf1
Compare
this happens when ids of doctype or html element are changed in the virtual dom also improve the code quality
|
Sure. Give me a day and I'll get back to ya. |
b0dae82 to
8eaf2d3
Compare
Juice10
approved these changes
Feb 9, 2023
Member
Juice10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @Mark-Fenng, much more readable!
Contributor
|
@Mark-Fenng Thanks for your great work and |
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the robustness of the virtual-dom implementation imported in #853 and fix some common errors such as #1042
Changes:
Now node matching doesn't only rely on the equality of serialized Ids
https://rrwebdebug.com/play/index.html?url=https%3A%2F%2Fgist.github.com%2FMark-Fenng%2Fdd95c2246c948ac1bda1c67336210fb1&version=1.0.0-alpha.4&play=on
Thanks for @pdwittig 's really helpful events
This bug is because class selector matching in auto-mounted iframes is case-insensitive.
afterAppendhook to the diff functionfix: virtual nodes are passed to plugin's onBuild callback
@bhavitsharma Could you please also review this PR in case I'm missing anything important? Since you have followed some related problems and you are also familiar with the code.