fix: module error #1087
Merged
fix: module error #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor all suffix of bundled scripts with commonjs module from 'js' to cjs error: ReferenceError: exports is not defined in ES module scope This file is being treated as an ES module because it has a '.js' file extension and '.../rrweb/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
YunFeng0817
force-pushed
the
fix-module-type
branch
from
2bcecbe to
b8db3dd
Compare
Juice10
approved these changes
Jan 10, 2023
Member
Juice10
left a comment
Juice10
left a comment
There was a problem hiding this comment.
This is the way forward IMO, and 2.0 is the right moment to do it. I believe I did something similar in the vite.js branch, but that one isn’t finished yet so I’m happy we could get this in sooner
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Contributor
This is the case with jsdelivr I believe; e.g. the following fails as it's served as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1056
Reason
In #976, a property
type: "module"was added to the package.json. When it is set to "module", the type field allows a package to specify all .js files within are ES modules. If the "type" field is omitted or set to "commonjs", all .js files are treated as CommonJS. So all scripts under rrweb/lib/** are treated as esm format by JS bundlers unexpectedly.Fix
Change all suffixes of bundled scripts with commonjs module from 'js' to cjs.
The file suffix of all scripts under rrweb/lib/* is changed from js to cjs. This may cause programs that import rrweb through CDN links to fail.