Fix missed adopted style sheets of shadow doms in checkout full snapshot #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juice10
reviewed
Jan 9, 2023
…t is checked out after recording has started
… a new full snapshot
Co-authored-by: Justin Halsall <[email protected]>
YunFeng0817
force-pushed
the
fix-adopted-style-sheets
branch
from
3ba2e08 to
81dc458
Compare
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
AdoptedStyleSheets in shadow doms are missed when a full snapshot is checked out after the recording has started.
This bug can be reproduced through the created test case.
Error test snapshot:
adoptedStylesheets data is missed in the second full snapshot.
Expected test snapshot:
New adoptedStylesheets data is also generated in the second full snapshot.