Fix: Capture CSS background-clip: text with browser prefix
#1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Nov 8, 2022
up to rrweb-io/rrweb#1045 applies preview change rrweb-io/rrweb#1047
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Nov 11, 2022
up to rrweb-io/rrweb#1045 applies preview change rrweb-io/rrweb#1047
This was referenced Jul 6, 2023
| !cssText.includes(' -webkit-background-clip: text;') | ||
| ) { | ||
| cssText = cssText.replace( | ||
| ' background-clip: text;', |
Contributor
There was a problem hiding this comment.
The javascript replace notoriously only replaces the first occurrence right?
Suggest
- ' background-clip: text;',
- / background-clip: text;/g,
or similar with a precompiled regex
Member
Author
There was a problem hiding this comment.
Good catch! Can you make a PR for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome outputs
-webkit-background-clipasbackground-clipinCSSStyleRule.cssText.But then Chrome ignores
background-clipas css input.This PR re-introduces
-webkit-background-clipto fix this issue.