Implement: Inactive activity indicator on progress bar #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Controller.svelte: add a fixed div element as an indicator
… function to get inactive periods
…ods-and-use-util update Controller.svelte: add a variable inactivePeriods and use util
update Controller.svelte: add width property for inactive activity indicators
…ith-indicator-UI update Controller.svelte: combine calculation value with indicator UI
update Controller.svelte: apply Zihan's suggestion #5 (comment)
apply code review suggestions
implement inactive activity indicator on progress bar including following features: a util function for detecting inactive periods implementation of indicator UI on progress bar get session events in Control.svelte and invoke util function to get invalid periods calculate width of indicator according to the period length combine calculation value with indicator UI manual test and bug fix improved code quality
Yuyz0112
reviewed
Oct 29, 2022
Member
Yuyz0112
left a comment
Yuyz0112
left a comment
There was a problem hiding this comment.
very cool, looks like we can move some utils to a shared package in the future!
update index.d.ts: add type definition for the color option
apply review suggestion
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before implementing this feature:
There was no way to view which part of the replay is inactive.
After implementing this feature:
The part of progress bar that contains non-active user behavior becomes gray so that the user can choose to skip it or not. We have created a function to detect inactive events or cycles and added a div tag to the progress bar within a cycle as an indicator
Demonstration video:
The screen on the left is the previous replayer, the one on the right is latest replayer after implementing this feature:
demo_edited.mp4
close #621