shadow root use the correct dom in iframe #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunFeng0817
approved these changes
Oct 28, 2022
Member
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
Thanks for your fix. I'm surprised this bug existed for such a long time. Could you also describe the behaviour of issues this bug has caused?
Contributor
Author
|
Sorry, I just read the source code and thought it was a mistake |
Juice10
approved these changes
Nov 4, 2022
Yuyz0112
approved these changes
Nov 13, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.