Cross origin iframe support #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I am so excited about this great work! |
This was referenced Nov 2, 2022
Yuyz0112
reviewed
Nov 3, 2022
Member
|
100% agree with the current approach |
|
Thank you for dropping the ancestororigins use to let this support Firefox! |
YunFeng0817
approved these changes
Nov 13, 2022
Yuyz0112
approved these changes
Nov 16, 2022
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Jan 9, 2023
## Summary Brings in rrweb-io/rrweb#1035 and adds options to the client to support the new feature. Customers who are interested in using cross-origin iframe recording will add `H.init` to their app as well as to their iframe page, but with a new option `isCrossOriginIframe: true` Related PRs: * highlight/highlight-javascript#7 * highlight/rrweb#99 * highlight/docs#28 Iframe network/console recording will be handled separately by HIG-3496. Cross-origin recording of network/console messages would require similar `postMessage` forwarding. This change also turns off rrweb record start/stopping because rrweb has some bugs in that it does not clean up all of its even listeners on record stop, causing a subsequent record restart to add duplicate listeners. Also closes HIG-3557 ## How did you test this change? With the change: https://www.loom.com/share/4e0cc7663b0344f6989bd56659d70b13 Without the change, the same iframe does not get recorded: https://www.loom.com/share/32403b5bef4645609527721eeb415364 ## Are there any deployment considerations? New version.
This was referenced Jul 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for recording cross origin iframes.
As long as rrweb is present in both top level frame a child iframe, the child iframe will send rrweb events to its parent for processing and emitting.
Demo: Cross origin iframe recording in action
cross.origin.iframe.recording.mov
Demo:
canvas-webrtcplugin also supportedwebrtc.in.nested.cross.origin.iframes.mov
Breaking changes compared to rrweb 2.0.0.alpha.3 (but not present in rrweb 1.x):
getMirror()arguments have changed and now expects multiple mirrors as opposed to just oneOther changes:
TODO: