Chore: Move most types from rrweb to @rrweb/types package #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juice10
changed the title
…rweb into @juice10/@rrweb/types
YunFeng0817
reviewed
Oct 22, 2022
Juice10
commented
Oct 22, 2022
YunFeng0817
approved these changes
Oct 23, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rrdom depends on rrweb, and rrweb depends on rrdom, this creates circular dependencies.
To break the circle I moved all of the types rrdom depends on, and most of the types rrweb uses to their own package: @rrweb/types
This PR also uses vite which I will be migrating the whole of the project towards in favor of the different custom rollup scripts we have.