Update Player.svelte: fix the bug. #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The progress bar and controls now can be displayed under the fullscreen mode.
This was referenced Oct 23, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fixing the bug:
In full-screen mode, there is no progress bar or control panel.
Bugs appear in browsers: Chrome, Safari and Edge.
Causes of bugs and repair ideas:
By checking the component code, the height of the content under the rr-player__frame tag is incorrectly calculated in full-screen mode, causing bugs to occur when the progress bar and control bar are rendered off-screen under the rr-controller tag. Fix the bug by modifying the way tag height is calculated.
After the bug fix:
In full-screen mode, the progress bar and control bar can be displayed under the playback screen normally.
Close #801.