Fix #972 [Docs]: Add Readme.md to packages/rrweb #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the README.md from source folder, change link dependencies
Fix the root directory reference
fix the typo
Juice10
approved these changes
Oct 17, 2022
Member
Juice10
left a comment
Juice10
left a comment
There was a problem hiding this comment.
This is really great @HurricaHjz! Thanks for contributing, we appreciate it!
Contributor
Author
|
Thanks Justin! I have formatted my code and push it, now it passed all the tests except Travis CI, and I don't know why. I have only changed the README.md file within package of rrweb. |
1 task
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! @Juice10! I have tried to create a simpler readme for the rrweb package based on the main README.md.
I have updated all the links and delete some description that's not used within this package. This PR resolves #972.
Please let me know if any further modification need to be made!
Thanks
Jerry