feat: support media playbackRate #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunFeng0817
reviewed
Sep 15, 2022
Member
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
All code looks good. To pass the prettier check CI, you may need to rebase the branch with the latest main branch and fix the format problem in observer.ts as well.
wfk007
force-pushed
the
support-media-playbackRate
branch
from
0db9cda to
6e0f348
Compare
wfk007
force-pushed
the
support-media-playbackRate
branch
from
8b6e958 to
ed2981a
Compare
YunFeng0817
approved these changes
Sep 15, 2022
Yuyz0112
approved these changes
Sep 15, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for media playbackRate change