Skip to content

[Bug]: recordCrossOriginIframes: true does not work with pack/unpack fn #1077

@thatsnotright

Description

@thatsnotright

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

latest from master

Expected Behavior

I expect recordCrossOriginIframes will show iframe content when injected in to all iframes, with a pack/unpackfn specified.

Actual Behavior

The mutations are captured for iframes but not processed unless I remove the packFn. If I specify a packFn for only the top-level rrweb this also works, so it's just in the child to parent messaging that the packFn causes this behavior.

Steps to Reproduce

Use the repl to get an IFrame site, and then add a packFn and see that it no longer renders cross-domain IFrame content.

I have an idea where to fix this that I'm looking at locally and I can submit a PR if I fix this behavior before anyone else does.

Testcase Gist URL

No response

Additional Information

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingfixedIssue has been fixedhas PRalready has pull request for it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions