Cleanups #139
Open
Cleanups #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark a function argument as unused and change the type of err in comps_parse_validate_dtd() to match what libxml returns. Signed-off-by: Dave Cantrell <[email protected]>
Mark some function attributes as unused and make some inline functions static, but primarily change from directly casting functions using (PyCFunction) to using _PyCFunction_CAST() in the PyMethodDef arrays. Signed-off-by: Dave Cantrell <[email protected]>
Fix a number of compiler warnings in the test suite. This is mostly from type mismatches that the compiler casted anyway. Also, replace the use of the deprecated fail_if() macro from libcheck with the proper ck_assert macro. Signed-off-by: Dave Cantrell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiler warnings, replace deprecated code with non-deprecated code.