Skip to content

fix duplicate tool calls #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parent: Dev changes
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix duplicate tool calls #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/rowboat/app/lib/agents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,10 @@ export async function* streamResponse(
const usageTracker = new UsageTracker();
const turnMsgs: z.infer<typeof Message>[] = [...messages];

// Add deduplication tracking for tool calls
const processedToolCallIds = new Set<string>();
const processedToolResponseIds = new Set<string>();

logger.log('🎬 STARTING AGENT TURN');

// stack-based agent execution loop
Expand Down Expand Up @@ -1208,6 +1212,15 @@ export async function* streamResponse(
// handle tool call invocation
// except for transfer_to_* tool calls
if (output.type === 'function_call' && !output.name.startsWith('transfer_to')) {
// Check if this tool call has already been processed
if (processedToolCallIds.has(output.callId)) {
eventLogger.log(`⚠️ SKIPPING: tool call ${output.callId} (${output.name}) already processed`);
continue;
}

// Mark this tool call as processed
processedToolCallIds.add(output.callId);

const m: z.infer<typeof Message> = {
role: 'assistant',
content: null,
Expand Down Expand Up @@ -1309,6 +1322,16 @@ export async function* streamResponse(
event.item.rawItem.type === 'function_call_result' &&
event.item.rawItem.status === 'completed' &&
event.item.rawItem.output.type === 'text') {

// Check if this tool response has already been processed
if (processedToolResponseIds.has(event.item.rawItem.callId)) {
eventLogger.log(`⚠️ SKIPPING: tool response ${event.item.rawItem.callId} (${event.item.rawItem.name}) already processed`);
continue;
}

// Mark this tool response as processed
processedToolResponseIds.add(event.item.rawItem.callId);

const m: z.infer<typeof Message> = {
role: 'tool',
content: event.item.rawItem.output.text,
Expand Down