Skip to content

Conversation

@UjjwalTiwari00
Copy link

No description provided.

@vercel
Copy link

vercel bot commented May 29, 2025

@UjjwalTiwari00 is attempting to deploy a commit to the RowBoat Labs Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ramnique
Copy link
Contributor

ramnique commented Jun 2, 2025

Hi @UjjwalTiwari00

Here are some observations from my review:

  • This project uses already uses UI components from HeroUI, shadcn, etc. HeroUI also has a Toast component available. Can we use that instead of adding a new dependency?
  • The idea behind Better error reporting for known errors #142 is to also propagate certain errors, such as running out of OpenAI credits. Can we add the necessary changes for that as well? Currently this seems mostly like a UI change.
  • Removing setFetchResponseError('Error: ' + JSON.parse(event.data).error); from the chat component also removes the ability for the user to retry the action. We need to think of how to keep that ability while also using toast vs not using toast in certain UX flows.
  • This PR needs to be merged into dev, not main

Currently, the changes are only related to the look-and-feel. It would be sensible to also include changes related to propagation of meaningful errors from the backend and upstream services (like agents service / copilot, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants