Skip to content

Conversation

@mini-1235
Copy link
Contributor

@mini-1235 mini-1235 commented Nov 9, 2025

Description

Related to ros2/rclcpp#2975, ConstSharedPtr is preferred

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@mini-1235
Copy link
Contributor Author

It seems like it is used, I will need to check again

@mini-1235 mini-1235 marked this pull request as draft November 9, 2025 11:29
Signed-off-by: mini-1235 <[email protected]>
@mini-1235 mini-1235 changed the title Remove unnecessary subscription in test Update subscription callback signatures Nov 9, 2025
@mini-1235 mini-1235 marked this pull request as ready for review November 9, 2025 11:54
@ahcorde
Copy link
Contributor

ahcorde commented Nov 10, 2025

Pulls: #222
Gist: https://gist.githubusercontent.com/ahcorde/9cfe8cb2d26267a971a5c4c88ff99111/raw/8674960178280452e3347a22b6f05dd564895c55/ros2.repos
BUILD args: --packages-up-to message_filters --packages-above-and-dependencies message_filters
TEST args: --packages-select message_filters --packages-above message_filters
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17435

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 59c7729 into ros2:rolling Nov 10, 2025
2 checks passed
@mini-1235 mini-1235 deleted the patch-1 branch November 10, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants