Skip to content

tf2_ros: Fix deprecated subscriber callbacks #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021
Merged

tf2_ros: Fix deprecated subscriber callbacks #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25dcf26
`tf2_monitor`: Fix deprecated sub callbacks
Aug 20, 2021
9650e07
`transform_listener`: Fix deprecated sub callbacks
Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tf2_ros/include/tf2_ros/transform_listener.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class TransformListener
{
node_logging_interface_ = node->get_node_logging_interface();

using callback_t = std::function<void (tf2_msgs::msg::TFMessage::SharedPtr)>;
using callback_t = std::function<void (tf2_msgs::msg::TFMessage::ConstSharedPtr)>;
callback_t cb = std::bind(
&TransformListener::subscription_callback, this, std::placeholders::_1, false);
callback_t static_cb = std::bind(
Expand Down Expand Up @@ -149,7 +149,7 @@ class TransformListener

/// Callback function for ros message subscriptoin
TF2_ROS_PUBLIC
void subscription_callback(tf2_msgs::msg::TFMessage::SharedPtr msg, bool is_static);
void subscription_callback(tf2_msgs::msg::TFMessage::ConstSharedPtr msg, bool is_static);

// ros::CallbackQueue tf_message_callback_queue_;
using thread_ptr =
Expand Down
2 changes: 1 addition & 1 deletion tf2_ros/src/tf2_monitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class TFMonitor
tf2_msgs::msg::TFMessage message_;
std::mutex map_mutex_;

void callback(const tf2_msgs::msg::TFMessage::SharedPtr msg)
void callback(const tf2_msgs::msg::TFMessage::ConstSharedPtr msg)
{
const tf2_msgs::msg::TFMessage & message = *(msg);
// TODO(tfoote): recover authority info
Expand Down
2 changes: 1 addition & 1 deletion tf2_ros/src/transform_listener.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void TransformListener::initThread(
}

void TransformListener::subscription_callback(
const tf2_msgs::msg::TFMessage::SharedPtr msg,
const tf2_msgs::msg::TFMessage::ConstSharedPtr msg,
bool is_static)
{
const tf2_msgs::msg::TFMessage & msg_in = *msg;
Expand Down