Skip to content

Corrects link to Matrix chat #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Corrects link to Matrix chat #464

merged 1 commit into from
Mar 10, 2025

Conversation

abhishek47kashyap
Copy link
Contributor

In CONTRIBUTING.md, the link to Matrix chat +rosorg-rust is no longer valid, this PR changes it to !AiYXdTWExqamTdatBl (obtained from #286)

mxgrey
mxgrey approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the old link stalled out when I tried to visit it, and the new link in the PR took me to the correct matrix room.

esteve
esteve approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek47kashyap thanks!

@esteve esteve merged commit caacf4d into ros2-rust:main Mar 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

+1 more reviewer

@mxgrey mxgrey mxgrey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishek47kashyap @esteve @mxgrey