Parsing of the message structure from introspection typesupport library #287
Conversation
|
@nnmm I won't be able to review this until next week or maybe even later. Given that this PR is not a priority, would you be ok with waiting until then? Thanks |
|
@esteve Sure. I'll probably open one or more other PRs for this feature that you can batch review when you have time. |
This module provides a nice tree representation of the message structure.
|
I forgot that I had written a test for this. Added now. |
nnmm
force-pushed
the
dynamic_messages_3
branch
from
0f4d847 to
e468712
Compare
nnmm
force-pushed
the
dynamic_messages_3
branch
from
e468712 to
e1efd85
Compare
| @@ -1,5 +1,8 @@ | |||
| #![cfg(test)] | |||
|
|
|||
| mod client_service_tests; | |||
| // Disabled in Foxy due to https://github.com/ros2/rosidl/issues/598 | |||
| #[cfg(all(not(ros_distro = "foxy"), not(ros_distro = "galactic")))] | |||
There was a problem hiding this comment.
Why was this disabled for Galactic? It seemed that only Foxy was affected
There was a problem hiding this comment.
No, actually also Galactic. I was wrong at first – should correct the comment.
There was a problem hiding this comment.
As proof, I removed the galactic part temporarily: https://github.com/ros2-rust/ros2_rust/actions/runs/3452502455/jobs/5762451384
There was a problem hiding this comment.
In that case, can you update the comment to mention galactic as well, instead of only foxy? Thanks
There was a problem hiding this comment.
@nnmm can you update the comment here? I can push the change, but given that this PR is part of a bigger PR, I thought of leaving it to you.
|
@esteve could you take another look please? |
|
@nnmm closing for now since we have had time to revisit this PR in a long time. Let us know if you'd like to work on it in the future. Thanks! |
This module provides a nice tree representation of the message structure.