Skip to content

Fix a segfault when re-using wait set #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix a segfault when re-using wait set #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclrs/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ pub use wait::*;
///
/// [1]: crate::RclReturnCode
pub fn spin_once(node: &Node, timeout: Option<Duration>) -> Result<(), RclrsError> {
let mut wait_set = WaitSet::new_for_node(node)?;
let wait_set = WaitSet::new_for_node(node)?;
let ready_entities = wait_set.wait(timeout)?;

for ready_subscription in ready_entities.subscriptions {
Expand Down
2 changes: 1 addition & 1 deletion rclrs/src/wait.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ impl WaitSet {
/// This list is not comprehensive, since further errors may occur in the `rmw` or `rcl` layers.
///
/// [1]: std::time::Duration::ZERO
pub fn wait(&mut self, timeout: Option<Duration>) -> Result<ReadyEntities, RclrsError> {
pub fn wait(mut self, timeout: Option<Duration>) -> Result<ReadyEntities, RclrsError> {
let timeout_ns = match timeout.map(|d| d.as_nanos()) {
None => -1,
Some(ns) if ns <= i64::MAX as u128 => ns as i64,
Expand Down