xml_reflection: First step to enable deprecation of public access #35
+603
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eacousineau
force-pushed
the
feature/cleanup
branch
from
0b8602d to
57f97bf
Compare
|
@clalancette Might you have time at some point to take a gander at this? |
|
@eacousineau Thanks for the pull request! Unfortunately I think the earliest we'll be able to review this is after the Crystal release in December. How soon would you like to see this PR in? |
sloretz
reviewed
Nov 20, 2018
|
You're welcome! And no rush on my part, December sounds good. Would be nice to start hiding the internals so they can either be simplified or stripped away at some point in lieu of something simpler. |
Clean up tests.
Update CHANGELOG for deprecating internal XML stuff
eacousineau
force-pushed
the
feature/cleanup
branch
from
57f97bf to
386d5c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in #34
Also cleans up the README. Can split that off into separate PR if so desired.