Skip to content

Add ros2plugin #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 6, 2025
Merged

Add ros2plugin #165

merged 8 commits into from
Oct 6, 2025

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Oct 4, 2019

Add the plugin command together with the list verb to ros2 CLI.

At the moment it produces the following results:

$ ros2 plugin list
demo_plugin_component:
	Plugin(name='ros2_playground::MessageWriterDerived', type='ros2_playground::MessageWriterDerived', base='ros2_playground::MessageWriter')
rviz_default_plugins:
	Plugin(name='rviz_default_plugins/Camera', type='rviz_default_plugins::displays::CameraDisplay', base='rviz_common::Display')
	Plugin(name='rviz_default_plugins/Grid', type='rviz_default_plugins::displays::GridDisplay', base='rviz_common::Display')
	...

while passing the flag --packages only list packages that export plugins and the relative path to the XML file(s ?),

$ ros2 plugin list --packages
demo_plugin_component:
	share/demo_plugin_component/plugins_description.xml
rviz_default_plugins:
	share/rviz_default_plugins/plugins_description.xml

I'd be more than open to discuss actual output and/or output layout.

Note this does not exactly mimic ROS 1 in terms of prints layout nor in terms of use (yet),
e.g. ROS 1 --> rospack plugins --attrib=plugin <base_package_name>.

Fix ros2/ros2cli#328
Replace ros2/ros2cli#340

Signed-off-by: artivis [email protected]

@artivis
add ros2plugin
d37b7ac 
Signed-off-by: artivis <[email protected]>
@nuclearsandwich
Copy link
Member

@ros-pull-request-builder retest this please

@nuclearsandwich nuclearsandwich self-requested a review October 14, 2019 21:37
@nuclearsandwich
Copy link
Member

@artivis I'll do an initial review of this PR, hopefully before the end of this week. Will you be able to assume maintainership of the ros2plugin package once it's merged? I'll take care of making sure you have the access you need and set up the necessary metadata to route notifications appropriately.

@artivis
Copy link
Contributor Author

artivis commented Oct 15, 2019

@nuclearsandwich yes I'll assume maintainership of the ros2plugin once merged 👍

@artivis
Copy link
Contributor Author

artivis commented Dec 18, 2019

@nuclearsandwich Hey, any update for this PR?

Arnatious
Arnatious reviewed Jan 11, 2020
View reviewed changes
Arnatious
Arnatious reviewed Jan 11, 2020
View reviewed changes
Arnatious
Arnatious reviewed Jan 11, 2020
View reviewed changes
Arnatious
Arnatious reviewed Jan 11, 2020
View reviewed changes
Arnatious
Arnatious reviewed Jan 11, 2020
View reviewed changes
@artivis
fix typo
69fb259 
Signed-off-by: artivis <[email protected]>
@artivis
Copy link
Contributor Author

artivis commented Jan 13, 2020

Good catch, thanks @Arnatious!

@nuclearsandwich nuclearsandwich added the ros2 Issues and PRs relating to ROS 2 label Apr 21, 2020
@kyrofa
Copy link

kyrofa commented Jun 5, 2020

@nuclearsandwich gentle ping on this.

@doisyg
Copy link

doisyg commented Jan 19, 2022

Any update on this ? Or is there already a way of listing installed plugins ?

@audrow audrow changed the base branch from ros2 to rolling June 28, 2022 14:17
@HansRobo
Copy link

@nuclearsandwich
I'm looking forward to this feature, any plans to merge it in ros2?

@ljaniec
Copy link

ljaniec commented Dec 6, 2022

Hello, @nuclearsandwich @artivis @Arnatious @audrow

What is missing from this PR before it can be merged?

Best,
Łukasz

@mnumanuyar
Copy link

any news on this ?

@jonselling
Copy link

I was hoping this feature would be in ROS 2, is there any plans to merge this in or get it looked at again?

@esteve
Copy link
Member

esteve commented Apr 10, 2024

@Arnatious @nuclearsandwich is there anything else that needs to be addressed for this PR? It'd be a great functionality for the ros2 cli. Thanks.

@quantumxt
Copy link

Is there any update on this feature?

ahcorde
ahcorde approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included some changes

  • move plugin lib to it own directory pluginlib
  • now ros2plugin is also in it own directory ros2plugin

Made some required changes to make it work in the current rolling

@nuclearsandwich @sloretz @mjcarroll @esteve do you mind to take a look ?

@ahcorde
make linters happy
e89a673 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Oct 2, 2025 •
edited
Loading

Pulls: #165
Gist: https://gist.githubusercontent.com/ahcorde/36d709d1e2b3b30dd91987bd65b42a72/raw/f299c685834b2665e8cc816cc370f443fc67df5d/ros2.repos
BUILD args: --packages-above-and-dependencies pluginlib ros2plugin
TEST args: --packages-above pluginlib ros2plugin
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17148

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

mjcarroll
mjcarroll approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for resurrecting this and getting it across the line!

LGTM with Green CI.

Also, should we consider adding types while we are in here so we don't backslide on what @InvincibleRMC has been doing?

@InvincibleRMC
Copy link

Also, should we consider adding types while we are in here so we don't backslide on what @InvincibleRMC has been doing?

Since this feature seems highly requested its probably best to add in a follow up and not consider it as a blocker.

@ahcorde
Copy link
Contributor

ahcorde commented Oct 3, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 1a596d6 into ros:rolling Oct 6, 2025
3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Oct 6, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify Mergify
Copy link

mergify bot commented Oct 6, 2025 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 6, 2025
@artivis @mergify
Add ros2plugin (#165)
714514a 
Signed-off-by: artivis <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 1a596d6)

# Conflicts:
#	pluginlib/src/list_plugins.cpp
@mergify mergify bot mentioned this pull request Oct 6, 2025
Merged
mergify bot pushed a commit that referenced this pull request Oct 6, 2025
@artivis @mergify
Add ros2plugin (#165)
a448272 
Signed-off-by: artivis <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 1a596d6)

# Conflicts:
#	pluginlib/include/pluginlib/class_desc.hpp
#	pluginlib/include/pluginlib/class_list_macros.hpp
#	pluginlib/include/pluginlib/impl/split.hpp
#	pluginlib/src/list_plugins.cpp
#	pluginlib/test/include/test_base.hpp
#	pluginlib/test/include/test_plugins.hpp
#	pluginlib/test/include/visibility_control.hpp
#	pluginlib/test/test_plugins.cpp
@mergify mergify bot mentioned this pull request Oct 6, 2025
Merged
mergify bot pushed a commit that referenced this pull request Oct 6, 2025
@artivis @mergify
Add ros2plugin (#165)
9b2773d 
Signed-off-by: artivis <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 1a596d6)

# Conflicts:
#	pluginlib/include/pluginlib/class_desc.hpp
#	pluginlib/include/pluginlib/class_list_macros.hpp
#	pluginlib/include/pluginlib/impl/split.hpp
#	pluginlib/src/list_plugins.cpp
#	pluginlib/test/include/test_base.hpp
#	pluginlib/test/include/test_plugins.hpp
#	pluginlib/test/include/visibility_control.hpp
#	pluginlib/test/test_plugins.cpp
@mergify mergify bot mentioned this pull request Oct 6, 2025
Merged
ahcorde added a commit that referenced this pull request Oct 9, 2025
@mergify @ahcorde
Add ros2plugin (backport #165) (#280)
b0a2ca8 
* Add ros2plugin (#165)

Signed-off-by: artivis <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 1a596d6)
ahcorde added a commit that referenced this pull request Oct 9, 2025
@mergify @ahcorde
Add ros2plugin (backport #165) (#279)
d2900ea 
* Add ros2plugin (#165)

Signed-off-by: artivis <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 1a596d6)
ahcorde added a commit that referenced this pull request Oct 10, 2025
@mergify @ahcorde
Add ros2plugin (backport #165) (#281)
8334a21 
* Add ros2plugin (#165)

Signed-off-by: artivis <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 1a596d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

+1 more reviewer

@Arnatious Arnatious Arnatious left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ros2 Issues and PRs relating to ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ros2plugin] Request for pluginlib cli