Fix namespace and pkg name of nodelets #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we display "DEPRECATED message" when someone using old API? |
|
I think we need to create another nodelet class to do that, because resolving name is the task of loader, and the loader is in |
- modified: ../../nodelet_plugins.xml - modified: adding_images_nodelet.cpp - modified: camshift_nodelet.cpp - modified: color_filter_nodelet.cpp - modified: contour_moments_nodelet.cpp - modified: convex_hull_nodelet.cpp - modified: corner_harris_nodelet.cpp - modified: discrete_fourier_transform_nodelet.cpp - modified: edge_detection_nodelet.cpp - modified: face_detection_nodelet.cpp - modified: fback_flow_nodelet.cpp - modified: find_contours_nodelet.cpp - modified: general_contours_nodelet.cpp - modified: goodfeature_track_nodelet.cpp - modified: hough_circles_nodelet.cpp - modified: hough_lines_nodelet.cpp - modified: lk_flow_nodelet.cpp - modified: people_detect_nodelet.cpp - modified: phase_corr_nodelet.cpp - modified: segment_objects_nodelet.cpp - modified: simple_compressed_example_nodelet.cpp - modified: simple_example_nodelet.cpp - modified: simple_flow_nodelet.cpp - modified: smoothing_nodelet.cpp - modified: threshold_nodelet.cpp - modified: watershed_segmentation_nodelet.cpp
|
Added DeprecationWarning: |
|
@k-okada I think this is the most user friendly way to rename the nodelet. What do you think about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #21