Fix overriding of install (backport of #510) #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix overriding of install Signed-off-by: Tyler Weaver <[email protected]> * Update admittance_controller/CMakeLists.txt Co-authored-by: Chris Thrasher <[email protected]> * Update ros2_controllers/CMakeLists.txt Co-authored-by: Chris Thrasher <[email protected]> * Remove unused lists * Use THIS_PACKAGE_INCLUDE_DEPENDS list --------- Signed-off-by: Tyler Weaver <[email protected]> Co-authored-by: Chris Thrasher <[email protected]>
github-actions
bot
requested review from
anfemosa,
bijoua29,
bmagyar,
destogl,
harderthan,
livanov93 and
progtologist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done in #510 this installs the headers correctly on Humble. I resolved one merge request, but this PR does update the required CMake version, as well. I hope this is fine, otherwise please let me know.
As discussed with @destogl this would be nice to have in Humble, as well, see UniversalRobots/Universal_Robots_ROS2_Driver#656.