Skip to content

Conversation

@bmagyar
Copy link
Member

@bmagyar bmagyar commented Sep 18, 2021

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the first port. Do not forget open a follow-up issue where the paramters should be used by the controllers.

Co-authored-by: Victor Lopez <[email protected]>
@destogl destogl merged commit 177b174 into ros-controls:master Sep 21, 2021
gwalck pushed a commit to b-robotized-forks/ros2_controllers that referenced this pull request Jun 7, 2023
* Use constants instead of strings in tests

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants